Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TemplateLoading error as "UnprocessableEntity" #19445

Merged
merged 5 commits into from
Apr 22, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 20, 2022

- Don't return Internal Server error if the user provide incorrect label
template, instead return UnprocessableEntity.
- Resolves go-gitea#19399
@Gusted Gusted added this to the 1.17.0 milestone Apr 20, 2022
@Gusted Gusted added type/bug modifies/api This PR adds API routes or modifies them backport/v1.16 labels Apr 20, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Apr 20, 2022
- Backport go-gitea#19445
  - Don't return Internal Server error if the user provide incorrect label template, instead return UnprocessableEntity.
  - Resolves go-gitea#19399
@Gusted Gusted added the backport/done All backports for this PR have been created label Apr 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2022
@6543 6543 merged commit 240b3aa into go-gitea:main Apr 22, 2022
6543 pushed a commit that referenced this pull request Apr 22, 2022
* Mark TemplateLoading error as "UnprocessableEntity" (#19445)

- Backport #19445
  - Don't return Internal Server error if the user provide incorrect label template, instead return UnprocessableEntity.
  - Resolves #19399

- dep: upgrade: github.com/gogs/chardet
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 23, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Mark TemplateLoading error as "UnprocessableEntity" (go-gitea#19445)
  Prevent dangling cat-file calls (goroutine alternative) (go-gitea#19454)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
- Don't return Internal Server error if the user provide incorrect label
template, instead return UnprocessableEntity.
- Resolves go-gitea#19399
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Server error returned when doing a POST at /v1/user/repos with invalid data
6 participants